Disable param updating experiments when design matrix - #14209
Draft
tbwiik wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14209 +/- ##
==========================================
+ Coverage 91.93% 91.95% +0.01%
==========================================
Files 482 484 +2
Lines 33516 33647 +131
==========================================
+ Hits 30813 30940 +127
- Misses 2703 2707 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tbwiik
added
the
release-notes:improvement
Contributor
Author
|
Tooltip on disable leaks abstraction levels. Must handle that while still being informative. do in other issue. |
tbwiik
force-pushed
the
disable-param-update-models-on-matrix
branch
2 times, most recently
from
August 19, 2026 09:56
c680215 to
657d6ea
Compare
tbwiik
changed the title
tbwiik
force-pushed
the
disable-param-update-models-on-matrix
branch
from
August 19, 2026 13:06
6dee863 to
657d6ea
Compare
tbwiik
force-pushed
the
disable-param-update-models-on-matrix
branch
from
August 19, 2026 13:25
657d6ea to
efb4669
Compare
tbwiik
commented
Aug 19, 2026
Comment on lines
+206
to
+209
| merged_parameters = config.parameter_configurations_with_design_matrix | ||
| updatable_parameters_exist = any( | ||
| p.update_strategy is not None for p in merged_parameters | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
might be valuable to combine these two vars here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #14139
Approach
When design matrix is set, parameters are explicit and it should not be possible to run experiment types that updates parameters.
For this case, the parameter updating experiment types are now disabled in the main experiment drop down menu.
Original state:
State after disabling updating experiment types when design matrix present:
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.